Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Jakub Warczarek <[email protected]>
  • Loading branch information
pmalek and programmer04 authored Nov 19, 2024
1 parent 8f0a5ad commit 46d8b2b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion test/envtest/admission_webhook_envtest_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -673,7 +673,7 @@ func TestAdmissionWebhook_KongClusterPlugins(t *testing.T) {
// admission webhook "kongclusterplugins.validation.ingress-controller.konghq.com" denied
// the request: could not parse plugin configuration: Secret "cluster-conf-secret-valid-patch" not found
require.EventuallyWithT(t, func(t *assert.CollectT) {
require.NoError(t, ctrlClientGlobal.Create(ctx, tc.kongClusterPlugin))
assert.NoError(t, ctrlClientGlobal.Create(ctx, tc.kongClusterPlugin))
}, waitTime, tickTime,
)
t.Cleanup(func() {
Expand Down

1 comment on commit 46d8b2b

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Go Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 46d8b2b Previous: 6a2f8ad Ratio
BenchmarkGetPluginRelations 18224 ns/op 7296 B/op 66 allocs/op 8463 ns/op 7296 B/op 66 allocs/op 2.15
BenchmarkGetPluginRelations - ns/op 18224 ns/op 8463 ns/op 2.15

This comment was automatically generated by workflow using github-action-benchmark.

CC: @Kong/k8s-maintainers

Please sign in to comment.