-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(log): do not log errors when parentRef kind is not Gateway #6692
Conversation
f83d49f
to
c8af668
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6692 +/- ##
=======================================
+ Coverage 77.7% 77.9% +0.1%
=======================================
Files 203 203
Lines 23836 23832 -4
=======================================
+ Hits 18534 18570 +36
+ Misses 4351 4315 -36
+ Partials 951 947 -4 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that this became a problem how about adding a UT for IsRouteAttachedToReconciledGateway()
? This func is used across the code base in several place so IMHO it would be worth adding tests for it. WDYT?
c8af668
to
1a0fb69
Compare
1a0fb69
to
8c0b6c1
Compare
Added unit tests. |
What this PR does / why we need it:
Do not log errors when a
parentRef
item is not referencing aGateway
. It is possibly that the route is managed by some other controllers, like using service mesh.Which issue this PR fixes:
fixes #6584
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR