Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add KONG_CUSTOM_DOMAIN handling with sdk-konnect-go 0.1.7 #6695

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

pmalek
Copy link
Member

@pmalek pmalek commented Nov 19, 2024

What this PR does / why we need it:

Use https://github.com/Kong/sdk-konnect-go/releases/tag/v0.1.7.

Related issue: Kong/sdk-konnect-go#20

@pmalek pmalek added area/ci area/konnect Issues and PRs related to Konnect labels Nov 19, 2024
@pmalek pmalek self-assigned this Nov 19, 2024
@pmalek pmalek requested a review from a team as a code owner November 19, 2024 16:44
@pmalek pmalek enabled auto-merge (squash) November 19, 2024 16:44
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.8%. Comparing base (32c3b44) to head (d7c1e00).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##            main   #6695      +/-   ##
========================================
+ Coverage   44.0%   77.8%   +33.8%     
========================================
  Files        204     204              
  Lines      42247   23870   -18377     
========================================
- Hits       18593   18574      -19     
+ Misses     22710    4348   -18362     
- Partials     944     948       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@pmalek pmalek force-pushed the sdk-konnect-go-0.1.7-and-fixed-konnect-cleanup branch 3 times, most recently from df4e6b1 to efb7db2 Compare November 20, 2024 15:52
@pmalek pmalek merged commit 48e9abd into main Nov 21, 2024
42 checks passed
@pmalek pmalek deleted the sdk-konnect-go-0.1.7-and-fixed-konnect-cleanup branch November 21, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci area/konnect Issues and PRs related to Konnect size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants