-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: backendTLSPolicy controller #6712
Conversation
d462a5e
to
ca48fdb
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6712 +/- ##
=======================================
- Coverage 77.8% 77.7% -0.2%
=======================================
Files 204 206 +2
Lines 23870 24302 +432
=======================================
+ Hits 18590 18889 +299
- Misses 4337 4441 +104
- Partials 943 972 +29 ☔ View full report in Codecov by Sentry. |
ca48fdb
to
d712bbd
Compare
bca6175
to
08ea766
Compare
ed849f6
to
92d4676
Compare
92d4676
to
b18051f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this PR only include the controller to load BackendPolicies
into the storage?
Yes, I prefer to iterate on the problem instead of having a huge unique PR (as this is something that will likely require a big bunch of code). I improved the PR description to make clear what this PR does. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, only some minor comments.
8a36665
to
04ea1c5
Compare
This commit introduces a new BackendTLSPolicy Controller that implemented a very basic functionality. It is intended as the first building block for the BackendTLSPolicy feature. Signed-off-by: Mattia Lavacca <[email protected]>
.golangci.yaml has been updated to include the gatewayv1alpha3 group to the forbidigo rules. Signed-off-by: Mattia Lavacca <[email protected]>
Signed-off-by: Mattia Lavacca <[email protected]>
04ea1c5
to
bee10dc
Compare
Co-authored-by: Grzegorz Burzyński <[email protected]>
Signed-off-by: Mattia Lavacca <[email protected]>
What this PR does / why we need it:
This PR introduces the
BackendTLSPolicy
controller that does the following:BackendTLSPolicy
that triggered the reconciliation loopWhich issue this PR fixes:
Part of #6631
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR