Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(request): unspecified location goes in body, also for blob #120

Merged
merged 2 commits into from
Jun 17, 2024
Merged

fix(request): unspecified location goes in body, also for blob #120

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ffb854
fix(request): unspecified location goes in body, also for blob
Tieske Jun 14, 2024
b07928d
added to testcase
Tieske Jun 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,11 @@ Release process:
1. test installing the rock from LuaRocks


### 1.x.x unreleased

- fix: when a "blob" type has no location specified, then use it as the body, same as with other types.
[120](https://github.com/Kong/lua-resty-aws/pull/120)

### 1.5.0 (20-May-2024)

- feat: decode AWS api response json body with array metatable
Expand Down
2 changes: 0 additions & 2 deletions src/resty/aws/request/build.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,8 +187,6 @@ local function build_request(operation, config, params)
if config.protocol == "query" then
-- no location specified, but protocol is query, so it goes into query
request.query[name] = param_value
elseif member_config.type == "blob" then
request.body = param_value
else
-- nowhere else to go, so put it in the body (for json and xml)
body_tbl[name] = param_value
Expand Down
Loading