Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add hostPrefix #90

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

add hostPrefix #90

wants to merge 2 commits into from

Conversation

KamranBiglari
Copy link

No description provided.

@CLAassistant
Copy link

CLAassistant commented Sep 29, 2023

CLA assistant check
All committers have signed the CLA.

@KamranBiglari KamranBiglari mentioned this pull request Sep 29, 2023
@KamranBiglari
Copy link
Author

#57

Copy link
Member

@windmgc windmgc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, could you add some simple test case and a changelog entry?

src/resty/aws/init.lua Outdated Show resolved Hide resolved
@KamranBiglari
Copy link
Author

@windmgc Thank you for you changes. Where should I put changelog ?

This is required to SFN since startSyncExecution has hostPrefix which is different that sfn endpoint.

local AWS = require("resty.aws")
local aws = AWS()
local sfn = aws:SFN { region = "us-east-2" }
local results, err = sf:startSyncExecution  {
    stateMachineArn = ""
    input = cjson.encode( {} )
}

@Tieske
Copy link
Member

Tieske commented Oct 18, 2024

Thank you for you changes. Where should I put changelog ?

It's in the README, just add to the "unreleased" item at the top of the changelist (if there is none, then add one)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants