fix(wrt/wasmtime) do not override 'WASMTIME_BACKTRACE_DETAILS' if specified #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cified With `backtraces on`, `WASMTIME_BACKTRACE_DETAILS` is forcefully enabled. With `backtraces off` (default), `WASMTIME_BACKTRACE_DETAILS` still defaults to `0` but can be overridden if specified in the `env` directive. This commit also ensures the `env` directives in `TestWasm.pm` are actually injected, although it disables the injection since no environment variable is presently injected.
Pull Request Test Coverage Report for Build 5893648069
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
backtraces on,WASMTIME_BACKTRACE_DETAILSis forcefully enabled.With
backtraces off(default),WASMTIME_BACKTRACE_DETAILSstill defaults to0but can be overridden if specified in theenvdirective.This commit also ensures the
envdirectives inTestWasm.pmare actually injected, although it disables the injection since no environment variable is presently injected.