Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(metrics) drop 'mid' argument from ngx_wa_metrics_histogram_record #617

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

casimiro
Copy link
Contributor

The argument was only used when logging the histogram in debug mode. Since our tests don't assert on the actual value of 'mid', we don't really need to have it printed in logs.

Also, ngx_wa_metrics_record already prints the mid of the metric being updated.

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.83363%. Comparing base (3bb2f15) to head (8485b29).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##                main        #617   +/-   ##
=============================================
  Coverage   90.83363%   90.83363%           
=============================================
  Files             52          52           
  Lines          11204       11204           
=============================================
  Hits           10177       10177           
  Misses          1027        1027           
Files with missing lines Coverage Δ
src/common/metrics/ngx_wa_histogram.c 99.35484% <100.00000%> (ø)
src/common/metrics/ngx_wa_metrics.c 92.21790% <100.00000%> (ø)
src/common/metrics/ngx_wa_metrics.h 100.00000% <ø> (ø)

... and 2 files with indirect coverage changes

Flag Coverage Δ
unit 90.57160% <100.00000%> (-0.01018%) ⬇️
valgrind 82.51447% <100.00000%> (+0.06865%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

…ord`

The argument was only used when logging the histogram in debug mode.
Since our tests don't assert on the actual value of 'mid', we don't
really need to have it printed in logs.

Also, `ngx_wa_metrics_record` already prints the 'mid' of the metric
being updated.
@casimiro casimiro force-pushed the chore/metrics-drop-mid-argument branch from fb0ec58 to 8485b29 Compare October 24, 2024 18:04
@thibaultcha thibaultcha merged commit bee8b84 into main Oct 24, 2024
32 checks passed
@thibaultcha thibaultcha deleted the chore/metrics-drop-mid-argument branch October 24, 2024 21:14
@thibaultcha
Copy link
Member

Nice, always nice to keep things tidy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants