Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/set query merge #628

Closed
wants to merge 3 commits into from
Closed

Feat/set query merge #628

wants to merge 3 commits into from

Conversation

thibaultcha
Copy link
Member

No description provided.

...to clarify that it matches `":path"` (that is, path including
querystring), making the field name match the pseudo-header, as is the
case with the other entries in `ngx_http_proxy_wasm_dispatch_s`.
Copy link

codecov bot commented Nov 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.84507%. Comparing base (9238d4a) to head (b73b6c4).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##                main        #628         +/-   ##
===================================================
+ Coverage   90.84180%   90.84507%   +0.00327%     
===================================================
  Files             52          52                 
  Lines          11214       11218          +4     
===================================================
+ Hits           10187       10191          +4     
  Misses          1027        1027                 
Files with missing lines Coverage Δ
src/common/proxy_wasm/ngx_proxy_wasm_maps.c 93.54839% <100.00000%> (+0.07012%) ⬆️
src/http/proxy_wasm/ngx_http_proxy_wasm_dispatch.c 91.68704% <100.00000%> (ø)

... and 2 files with indirect coverage changes

Flag Coverage Δ
unit 90.58310% <100.00000%> (+0.00287%) ⬆️
valgrind 82.50735% <76.92308%> (-0.00123%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

---- 🚨 Try these New Features:

@thibaultcha thibaultcha deleted the feat/set-query-merge branch November 23, 2024 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants