[Issue - 3713] Extension - Fix bug validating recipient balance when sending Substrate token #3771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
🚀 Deployed on https://pr-3771--sw-web-runner.netlify.app |
bluezdot
reviewed
Oct 10, 2024
| @@ -189,7 +190,7 @@ export class BalanceService implements StoppableServiceInterface { | |||
| } | |||
|
|
|||
| /** Subscribe token free balance of an address on chain */ | |||
| @@ -189,7 +190,7 @@ export class BalanceService implements StoppableServiceInterface { | |||
| } | |||
|
|
|||
| /** Subscribe token free balance of an address on chain */ | |||
| public async subscribeTransferableBalance (address: string, chain: string, tokenSlug: string | undefined, extrinsicType?: ExtrinsicType, callback?: (rs: AmountData) => void): Promise<[() => void, AmountData]> { | |||
| public async subscribeBalance (address: string, chain: string, tokenSlug: string | undefined, balanceType: 'transferable' | 'total', extrinsicType?: ExtrinsicType, callback?: (rs: AmountData) => void): Promise<[() => void, AmountData]> { | |||
There was a problem hiding this comment.
Should better create BalanceType Enum
| @@ -1652,6 +1654,10 @@ export default class KoniExtension { | |||
| return await this.#koniState.balanceService.getTransferableBalance(address, networkKey, token, extrinsicType); | |||
| } | |||
|
|
|||
| private async getAddressTotalBalance ({ address, extrinsicType, networkKey, token }: RequestFreeBalance): Promise<AmountData> { | |||
There was a problem hiding this comment.
Recheck with _MANTA_ZK_CHAIN_GROUP case
# Conflicts: # packages/extension-base/src/services/balance-service/index.ts
…sending Substrate token
# Conflicts: # packages/extension-base/src/koni/background/handlers/Extension.ts
S2kael
force-pushed
the
koni/dev/issue-3713-v2
branch
from
cb34078 to
0ab4af8
Compare
…i/dev/issue-3713-v2 # Conflicts: # packages/extension-base/src/koni/background/handlers/Extension.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.