[Issue-3920] Show well-known tokens on top #3934
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-3934--sw-web-runner.netlify.app |
nampc1
approved these changes
Dec 19, 2024
S2kael
reviewed
Dec 19, 2024
nampc1
requested changes
Jan 2, 2025
|
|
||
| export interface PopularGroup { | ||
| tokens: Record<string, number>, | ||
| piority: number |
lw-cdm
reviewed
Jan 2, 2025
packages/extension-koni-ui/src/components/Modal/ReceiveModalNew/parts/TokenSelector.tsx
Outdated
Show resolved
Hide resolved
lw-cdm
reviewed
Jan 2, 2025
lw-cdm
reviewed
Jan 6, 2025
| } | ||
| }; | ||
|
|
||
| export const sortByTokenPopularity = (a: string, b: string, aIsPiorityToken: boolean, bIsPiorityToken: boolean, aPiority: number, bPiority: number): number => { |
lw-cdm
reviewed
Jan 6, 2025
|
|
||
| export const sortTokenByValue = (a: TokenBalanceItemType, b: TokenBalanceItemType): number => { | ||
| const convertValue = b.total.convertedValue.minus(a.total.convertedValue).toNumber(); | ||
| export interface TokenSort { |
There was a problem hiding this comment.
Rename the type to make them more meaningful and grammatically correct
lw-cdm
reviewed
Jan 6, 2025
| @@ -1709,6 +1709,13 @@ export interface RequestAddPspToken { | |||
| }; | |||
| } | |||
|
|
|||
| // Popular tokens | |||
|
|
|||
| export interface PopularGroup { | |||
There was a problem hiding this comment.
Rename the type to make them more meaningful and grammatically correct
lw-cdm
reviewed
Jan 6, 2025
| /* Ledger */ | ||
|
|
||
| /* Popular tokens */ | ||
| 'pri(popular.tokens)': [null, Record<string, PopularGroup>, Record<string, PopularGroup>]; |
lw-cdm
reviewed
Jan 6, 2025
| @@ -51,10 +54,12 @@ function Component ({ className = '', items, onCancel, onSelectItem }: Props): R | |||
| } | |||
|
|
|||
| return filteredList; | |||
| } else if (currentSearchText.toLowerCase() === '') { | |||
lw-cdm
reviewed
Jan 6, 2025
| const aHasBalance = (a.total && a.total.convertedValue.toNumber() !== 0) || (a.total && a.total.value.toNumber() !== 0); | ||
| const bHasBalance = (b.total && b.total.convertedValue.toNumber() !== 0) || (b.total && b.total.value.toNumber() !== 0); | ||
|
|
||
| const aPiority = a.multiChainAsset ? aIsPiorityToken ? (popularTokens[a.multiChainAsset].tokens)[a.slug] : 0 : aIsPiorityToken ? popularTokens[a.slug].piority : 0; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.