Base64 proposal #372
Merged
Base64 proposal #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilya-g
reviewed
Oct 17, 2024
| e.g., `Base64.getDecoder().decode(...)`. This led us to avoid separating the encoder and decoder into different entities. | ||
| We also didn't find evidence that the benefits of such a separation outweigh the usage inconvenience. | ||
| Second, encoding to `String` and decoding from `String` are considerably more popular than encoding to `ByteArray` and | ||
| decoding from `ByteArray`. Thus, we decided to make the more frequently used functions shorter. |
There was a problem hiding this comment.
Another reason was that a compound operation like "encode bytearray to base64 string + encode string to utf8 byte array" should have a compound name.
There was a problem hiding this comment.
The reverse operation (utf8 byte array -> string -> byte array) doesn't have a compound name.
There was a problem hiding this comment.
Yes, in that case we didn't complicate the name thanks to overloading on parameter types, but the main principle in naming holds, so it's worth to mention it.
ilya-g
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only comment here about the text itself. The discussion about the feature is done in #373.
This KEEP proposes to introduce a multiplatform API for Base64 encoding and decoding.