Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add importlib_metadata as a real dependency for now #548

Closed
wants to merge 1 commit into from

Conversation

akx
Copy link
Contributor

@akx akx commented Nov 21, 2023

This is an alternate take to #546 that will make this package installable in general without having to specify importlib_metadata as a downstream dependency.

Using importlib.metadata directly (as implemented in #546) is the better solution, but this should allow for releasing a 3.0.4 as a stopgap measure.

@akx
Copy link
Contributor Author

akx commented Nov 21, 2023

cc @gentooboontoo, if you want to release a 3.0.4 today before I get CI up and running and get a better fix in.

I locally tested that this builds a correct wheel that has the correct dependency:

$ unzip -p dist/pygal-3.0.3-py2.py3-none-any.whl pygal-3.0.3.dist-info/METADATA | grep -C5 importli
Classifier: Topic :: Multimedia :: Graphics :: Presentation
Provides: pygal
Requires-Python: >=3.8
Description-Content-Type: text/x-rst
License-File: COPYING
Requires-Dist: importlib-metadata
Provides-Extra: docs
Requires-Dist: sphinx ; extra == 'docs'
Requires-Dist: sphinx-rtd-theme ; extra == 'docs'
Requires-Dist: pygal-sphinx-directives ; extra == 'docs'
Provides-Extra: lxml

@gentooboontoo
Copy link
Member

Thanks. I have already added install_requires in 0a79838 but without a comment and I also forgot to remove importlib_metadata from tox.ini so PR rebased and merged 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants