Moved IConfigurationSerializer interface one level up

Kralizek · Jan 30, 2024 · eca33ba · eca33ba
1 parent 39d8162
commit eca33ba
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 19 deletions.
diff --git a/src/Objects/IConfigurationSerializer.cs b/src/Objects/IConfigurationSerializer.cs
@@ -1,6 +1,6 @@
 using System.Collections.Generic;
 
-namespace Kralizek.Extensions.Configuration.Internal;
+namespace Kralizek.Extensions.Configuration;
 
 public interface IConfigurationSerializer
 {

diff --git a/src/Objects/ObjectConfigurationExtensions.cs b/src/Objects/ObjectConfigurationExtensions.cs
@@ -1,4 +1,5 @@
 using System;
+using Kralizek.Extensions.Configuration;
 using Kralizek.Extensions.Configuration.Internal;
 
 // ReSharper disable CheckNamespace
@@ -13,13 +14,8 @@ public static IConfigurationBuilder AddObject(this IConfigurationBuilder configu
         {
             return configurationBuilder;
         }
-
-        if (rootSectionName == null)
-        {
-            throw new ArgumentNullException(nameof(rootSectionName));
-        }
 
-        configurationBuilder.Add(new ObjectConfigurationSource(serializer, objectToAdd, rootSectionName));
+        configurationBuilder.Add(new ObjectConfigurationSource(serializer, objectToAdd, rootSectionName ?? string.Empty));
 
         return configurationBuilder;
     }

diff --git a/tests/Tests.Objects/Internal/ObjectConfigurationProviderTests.cs b/tests/Tests.Objects/Internal/ObjectConfigurationProviderTests.cs
@@ -1,5 +1,6 @@
 using AutoFixture.Idioms;
 using AutoFixture.NUnit3;
+using Kralizek.Extensions.Configuration;
 using Kralizek.Extensions.Configuration.Internal;
 using Moq;
 using NUnit.Framework;

diff --git a/tests/Tests.Objects/NewtonsoftJsonObjectConfigurationExtensionsTests.cs b/tests/Tests.Objects/NewtonsoftJsonObjectConfigurationExtensionsTests.cs
@@ -3,6 +3,7 @@
 using Microsoft.Extensions.Configuration;
 using Moq;
 using NUnit.Framework;
+// ReSharper disable InvokeAsExtensionMethod
 
 namespace Tests;
 
@@ -34,10 +35,4 @@ public void AddObject_does_nothing_when_source_is_null(IConfigurationBuilder con
 
         Mock.Get(configurationBuilder).Verify(p => p.Add(It.IsAny<IConfigurationSource>()), Times.Never);
     }
-
-    [Test, CustomAutoData]
-    public void AddObject_throws_if_rootSectionName_is_null(IConfigurationBuilder configurationBuilder, object testSource)
-    {
-        Assert.Throws<ArgumentNullException>(() => NewtonsoftJsonObjectConfigurationExtensions.AddObjectWithNewtonsoftJson(configurationBuilder, testSource, null));
-    }
 }
diff --git a/tests/Tests.Objects/SystemTextJsonObjectConfigurationExtensionsTests.cs b/tests/Tests.Objects/SystemTextJsonObjectConfigurationExtensionsTests.cs
@@ -35,10 +35,4 @@ public void AddObject_does_nothing_when_source_is_null(IConfigurationBuilder con
 
         Mock.Get(configurationBuilder).Verify(p => p.Add(It.IsAny<IConfigurationSource>()), Times.Never);
     }
-
-    [Test, CustomAutoData]
-    public void AddObject_throws_if_rootSectionName_is_null(IConfigurationBuilder configurationBuilder, object testSource)
-    {
-        Assert.Throws<ArgumentNullException>(() => ObjectConfigurationExtensions.AddObject(configurationBuilder, testSource, null));
-    }
 }