Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update websocket handling, frontend updates, more bspline support #113

Merged
merged 73 commits into from
Sep 27, 2024

Conversation

Krande
Copy link
Owner

@Krande Krande commented Sep 27, 2024

A lot of new features and fixes

  • Fixes a bug in the sesam FEM reader where the optional flag nint (number of integration points) is not accepted on the GELTH flag
  • Fixes bugs introduced in the new Config class singleton behaviour.
  • A lot of improvements to the ACIS SAT reader capabilities. Now capable of reading various bspline curves and surfaces
  • Added a IFC to sqlite based on the patch from ifcopenshell. This is now used as a backend for querying ifc entities from the frontend
  • Replaced passing jsons with flatbuffers in websocket communications
  • Added a "RenderManager" class to simplify rendering pipeline for spatial, physical and FEM objects
  • Added more direct opencascade geometry serialization of Bspline curve and surface geometries (as alternative to passing them through ifcopenshell)
  • Added end to end testing of communication between client - websocket - react frontend using playwright
  • Added several tests for ACIS SAT conversion

closes or replaces:

Copy link

codspeed-hq bot commented Sep 27, 2024

CodSpeed Performance Report

Merging #113 will not alter performance

Comparing fix/from-fem-mat (7dbd2f3) with main (547d373)

Summary

✅ 5 untouched benchmarks

🆕 2 new benchmarks

Benchmarks breakdown

Benchmark main fix/from-fem-mat Change
🆕 test_from_abaqus_fem N/A 208.9 ms N/A
🆕 test_from_sesam_fem N/A 255.9 ms N/A

Copy link

👋 Hi there! I have checked your PR and found no issues. Thanks for your contribution!

PR Review:

I found no pr-related issues.

  • ✅ PR title is ok
  • ✅ Release label is ok
  • ✅ SOURCE_KEY is set as a secret
  • ✅ Calculated next version: "0.3.0"

Python Review:

I found no python-related issues.

Python Linting results:

  • ✅ Isort
  • ✅ Black
  • ✅ Ruff

Python Packaging results:

  • ✅ I found the PYPI_API_TOKEN secret.
Packaging Type Package Name Version
pyproject.toml ada-py 0.2.18
pypi ada-py 0.2.18

@Krande Krande merged commit 1b15c70 into main Sep 27, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant