-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core][CI][Win] Adding verbosity to detect oot #12528
Conversation
|
…atos into ci/fix-out-of-time
…into ci/fix-out-of-time
…ysics/Kratos into ci/fix-out-of-time
Ok with this disabled, win does not crash: My guess right now is that the source is the sparse matrix. Keep investigating |
@@ -255,7 +255,7 @@ jobs: | |||
- uses: actions/checkout@v4 | |||
- uses: actions/setup-python@v5 | |||
with: | |||
python-version: '3.8' | |||
python-version: '3.10' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
BTW 3.13 will be released in like 6 weeks ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then its time to move to 3.12 :D. Sadly seems that moving to 3.10 does not help :S
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@roigcarlo can you give me a quick rundown on what's going on? I know this oot issue has been around for quite a while, but not much else. Why would changing the python exec help?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Basically some python tests fail in windows since July. It began for no apparent reason. I tracked down that there were some updates to the Windows container but that's it. To my knowledge all tests failing involve reading (or maybe just using) csr matrices at some point.
After much testing I suspect that the error happens while calling the mm_read_banner
from the matrixmarket lib (mmio.h
and mmio.c
).
The problem is that in 3 months I have been unable to reproduce this anywhere, and the windows container used to run in the CI is not public because of licences issues.
maybe time to replace the MM reader? => #1689 |
|
…atos into ci/fix-out-of-time
Wii fixed. |
📝 Description
Trying to fix out of time memory on win
Do not approve this yet.