Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core][CI][Win] Adding verbosity to detect oot #12528

Closed
wants to merge 77 commits into from

Conversation

roigcarlo
Copy link
Member

📝 Description
Trying to fix out of time memory on win

  • Adding verbosity to detect oot test

Do not approve this yet.

@roigcarlo roigcarlo requested a review from a team as a code owner July 11, 2024 09:50
loumalouomega
loumalouomega previously approved these changes Jul 11, 2024
@roigcarlo
Copy link
Member Author

Do not approve this yet.

@roigcarlo roigcarlo requested a review from a team as a code owner July 12, 2024 10:20
@roigcarlo roigcarlo requested a review from a team as a code owner August 20, 2024 06:25
@roigcarlo
Copy link
Member Author

Ok with this disabled, win does not crash:
eigen_solvers
sparse_matrix_multiplication
rom_orchestrator

My guess right now is that the source is the sparse matrix.

Keep investigating

@@ -255,7 +255,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
with:
python-version: '3.8'
python-version: '3.10'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

BTW 3.13 will be released in like 6 weeks ;)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then its time to move to 3.12 :D. Sadly seems that moving to 3.10 does not help :S

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@roigcarlo can you give me a quick rundown on what's going on? I know this oot issue has been around for quite a while, but not much else. Why would changing the python exec help?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically some python tests fail in windows since July. It began for no apparent reason. I tracked down that there were some updates to the Windows container but that's it. To my knowledge all tests failing involve reading (or maybe just using) csr matrices at some point.

After much testing I suspect that the error happens while calling the mm_read_banner from the matrixmarket lib (mmio.h and mmio.c).

The problem is that in 3 months I have been unable to reproduce this anywhere, and the windows container used to run in the CI is not public because of licences issues.

@philbucher
Copy link
Member

maybe time to replace the MM reader? => #1689

@roigcarlo
Copy link
Member Author

maybe time to replace the MM reader? => #1689
Sadly, seems that the problem is not that. It fails just accessing the file descriptor

@roigcarlo
Copy link
Member Author

Wii fixed.

@roigcarlo roigcarlo closed this Oct 24, 2024
@roigcarlo roigcarlo deleted the ci/fix-out-of-time branch October 24, 2024 14:23
@loumalouomega
Copy link
Member

Wii fixed.
Wii-Console

Wii?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants