Skip to content

Commit

Permalink
[fix] Helm fix gpg signing target and workflow
Browse files Browse the repository at this point in the history
* the GnuPG v2 store the secret keyring using the format kbx and Helm
  works with the legacy gpg format.
* Enclosing within quotes to fix env interpolation

Signed-off-by: dd di cesare <[email protected]>
  • Loading branch information
didierofrivia committed Feb 4, 2025
1 parent e71c0da commit 7c5303e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/release-helm-chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
- name: Configure GPG Key
run: |
echo -n "$GPG_SIGNING_KEY" | base64 -d | gpg --import
echo -n "$GPG_SIGNING_KEY" | base64 -d > ~/.gnupg/pubring.gpg
env:
GPG_SIGNING_KEY: ${{ secrets.HELM_CHARTS_SIGNING_KEY }}

Expand Down
2 changes: 1 addition & 1 deletion make/helm.mk
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ GPG_KEY_UID ?= 'Kuadrant Development Team'
.PHONY: helm-package-sign
helm-package-sign: $(HELM) ## Package the helm chart and GPG sign it
# Package the helm chart and sign it
$(HELM) package --sign --key $(GPG_KEY_UID) $(CHART_DIRECTORY)
$(HELM) package --sign --key "$(GPG_KEY_UID)" $(CHART_DIRECTORY)

# GitHub Token with permissions to upload to the release assets
HELM_WORKFLOWS_TOKEN ?= <YOUR-TOKEN>
Expand Down

0 comments on commit 7c5303e

Please sign in to comment.