Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CEL Interperter for Conditions #354

Closed
wants to merge 12 commits into from
Closed

CEL Interperter for Conditions #354

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
9801078
Quick and dirty CEL support
alexsnaps Jan 12, 2024
5007c15
Bring back the original simple parsing, and only enable cel expressio…
chirino Jun 5, 2024
c063001
Don’t change the simple key encoding so that redis keys don’t change.
chirino Jun 5, 2024
c8ad128
Drop dead code, and cargo fmt.
chirino Jun 5, 2024
d42e6d2
Add feature cel_conditions feature flag.
chirino Jun 5, 2024
ff6d4ce
Fix clippy warnings.
chirino Jun 5, 2024
954485f
Add more cel tests, handle cases where the var variable name conflict…
chirino Jun 5, 2024
bb0278e
Use an assert_false! Macro for better test readability
chirino Jun 5, 2024
4f70031
cel: reserve _* identifiers for future internal use like adding
chirino Jun 5, 2024
4ab013f
Pickup updates cel 0.7.0 (patched) version.
chirino Jun 7, 2024
93795b1
Improve assert_false! Macro.
chirino Jun 7, 2024
45958e0
Show an alternative way to access the cel variable.
chirino Jun 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
241 changes: 241 additions & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions limitador/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ disk_storage = ["rocksdb"]
distributed_storage = ["tokio", "tokio-stream", "h2", "base64", "uuid", "tonic", "tonic-reflection", "prost", "prost-types"]
redis_storage = ["redis", "r2d2", "tokio"]
lenient_conditions = []
cel_conditions = []

[dependencies]
moka = { version = "0.12", features = ["sync"] }
Expand All @@ -33,6 +34,8 @@ async-trait = "0.1"
cfg-if = "1"
tracing = "0.1.40"
metrics = "0.22.3"
cel-parser = "0.6.0"
cel-interpreter = "0.5.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.7 is out and you inherited my lock file I guess… might deal with our size vs size() better...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated.


# Optional dependencies
rocksdb = { version = "0.22", optional = true, features = ["multi-threaded-cf"] }
Expand Down
Loading
Loading