Ignore authority header check when it contains | char
#73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have created an issue in the upstream so we can remove our fork in the future when it's fixed. hyperium/h2#619 |
|
As per our discussion of yesterday, do agree we can close this? |
|
Yup, can close now but the issue should remain open. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #53 by forking https://github.com/hyperium/h2 and allowing requests with authority header containing pipe
|characters.The fix is present at: rahulanand16nov/h2@d956cec
It's not a security risk since the authority header is used nowhere in the logic of limitador (correct me if I am wrong). A similar issue will be created in the dependencies repo to fix it.
An image that contains this fix and works:
quay.io/rahanand/limitador:test