Properly unban users that are banned on "site" #9818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xillibit
reviewed
Feb 8, 2025
| @@ -6,7 +6,7 @@ | |||
| * @package Kunena.Plugins | |||
| * @subpackage System | |||
| * | |||
| * @copyright Copyright (C) 2008 - @currentyear@ Kunena Team. All rights reserved. | |||
| * @copyright Copyright (C) 2008 - 2025 Kunena Team. All rights reserved. | |||
There was a problem hiding this comment.
It's useless to replace @currentyear@ because it's a variable
There was a problem hiding this comment.
Sorry. Have to check this every time as Dreamweaver does this. Will try to remember for next time.
xillibit
reviewed
Feb 8, 2025
| @@ -2,16 +2,16 @@ | |||
| <!DOCTYPE extension> | |||
| <extension version="2.5" type="plugin" group="system" method="upgrade"> | |||
| <name>plg_system_kunena</name> | |||
| <version>@kunenaversion@</version> | |||
There was a problem hiding this comment.
Same here, It's useless to replace it
xillibit
reviewed
Feb 8, 2025
| @@ -2,16 +2,16 @@ | |||
| <!DOCTYPE extension> | |||
| <extension version="2.5" type="plugin" group="system" method="upgrade"> | |||
| <name>plg_system_kunena</name> | |||
| <version>@kunenaversion@</version> | |||
| <creationDate>@kunenaversiondate@</creationDate> | |||
There was a problem hiding this comment.
Same here, It's useless to replace it
|
This morning, I set an expiration date for this afternoon for the same banned user on the live site, on a version on localhost, and on the modified version on localhost. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #9812 .
Summary of Changes
Testing Instructions
Ban user on "site" for a short time. Check after an hour if user is unbanned.
If you want to check quicker, change value on line 126
if ($timestamp - $lastCheck >= 3600) {