[MediaBundle] Fix for deleting media #3043
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix removing dirs
Fix removing dirs
…xcluding the removed from file system
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request will fix 2 bugs in the MediaBundle.
When using the command
php bin/console kuma:media:clean-deleted-media --forceto delete the files by the original filename, it will skip the files from the filesystem that have been renamed due to strange characters in the filename. Using the commandphp bin/console kuma:media:rename-soft-deleted -owill update the filename back to the original filename. However, it doesn't use the same method as when an user uploads a file so this command will not update the filename correctly.This fix will add the slugifier to the command so it will pass the same method when renaming the filename.
The command also expects the directory to be deleted. however, it uses a directory name to check if a file exists, so it fail on the check so it doesn't delete the directory.