Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(inference): enable generated YAML matches the correct resources #93

Merged
merged 3 commits into from
Sep 9, 2024

Conversation

kaysonyu
Copy link
Contributor

@kaysonyu kaysonyu commented Sep 6, 2024

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:

fix ollama image to be pulled;
correct the naming of resources (including length and case);
greatly change the commands to be executed in the container;
update inference module beta version


@kaysonyu kaysonyu changed the title fix(inference): enable YAML generated by kusion to generate k8s resources correctly fix(inference): enable generated YAML matches the correct resources Sep 6, 2024
Copy link
Contributor

@liu-hm19 liu-hm19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@liu-hm19 liu-hm19 merged commit cf03ae1 into KusionStack:main Sep 9, 2024
6 of 7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants