fix(app): incorrect allowance check on trade (#1004)

Kwenta · Sep 27, 2023 · 5a16dab · 5a16dab
1 parent e613efd
commit 5a16dab
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/packages/app/src/sections/futures/TradeConfirmation/TradeConfirmationModal.tsx b/packages/app/src/sections/futures/TradeConfirmation/TradeConfirmationModal.tsx
@@ -80,7 +80,6 @@ export default function TradeConfirmationModal({
 	const ethBalanceExceeded = useAppSelector(selectKeeperDepositExceedsBal)
 	const hasSlTp = useAppSelector(selectNewTradeHasSlTp)
 	const sltpValidity = useAppSelector(selectTradePanelSLTPValidity)
-	const swapToken = useAppSelector(selectSelectedSwapDepositToken)
 
 	const [overridePriceProtection, setOverridePriceProtection] = useState(false)
 	const [acceptedSLRisk, setAcceptedSLRisk] = useState(false)
@@ -147,7 +146,7 @@ export default function TradeConfirmationModal({
 
 	const buttonText = allowanceValid
 		? t(`futures.market.trade.confirmation.modal.confirm-order.${leverageSide}`)
-		: t(`futures.market.trade.confirmation.modal.approve-order`, { asset: swapToken })
+		: t(`futures.market.trade.confirmation.modal.approve-order`, { asset: 'sUSD' })
 
 	return (
 		<StyledBaseModal

diff --git a/packages/app/src/state/futures/smartMargin/selectors.ts b/packages/app/src/state/futures/smartMargin/selectors.ts
@@ -606,8 +606,7 @@ export const selectSmartMarginAllowanceValid = createSelector(
 	selectSmartMarginBalanceInfo,
 	selectAvailableMarginInMarkets,
 	selectSmartMarginMarginDelta,
-	selectSwapDepositAllowance,
-	({ freeMargin }, idleInMarkets, marginDelta, allowance) => {
+	({ freeMargin, allowance }, idleInMarkets, marginDelta) => {
 		const totalIdleMargin = freeMargin.add(idleInMarkets)
 		const marginDeposit = marginDelta.sub(totalIdleMargin)
 		return totalIdleMargin.gte(marginDelta) || wei(allowance || 0).gte(marginDeposit)