-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trade Panel Enhancements #2798
Trade Panel Enhancements #2798
Conversation
@0xlinus is attempting to deploy a commit to the Kwenta Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## dev #2798 +/- ##
=======================================
Coverage 51.52% 51.53%
=======================================
Files 425 425
Lines 13742 13767 +25
Branches 3046 3059 +13
=======================================
+ Hits 7081 7095 +14
- Misses 6395 6405 +10
- Partials 266 267 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, just one small clean up suggestion but not a blocker.
packages/app/src/sections/futures/EditPositionModal/EditStopLossAndTakeProfitModal.tsx
Outdated
Show resolved
Hide resolved
Good catch, thanks! |
Description
This PR fixes issues related to the TP/SL values shown in
EditStopLossAndTakeProfitModal
and inSLTPInputs
which display inaccurate data. It also adds extra information to the input.Related issue
#2797
Motivation and Context
This is also a technical assessment