Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom display value for ETHBTC, so dropdown shows "ETH/BTC". #2807

Closed
wants to merge 1 commit into from

Conversation

Ondkloss
Copy link
Contributor

Description

Added a custom handling of "ETHBTC" getDisplayAsset to return "ETH/BTC".
Value should appear in market dropdown.

Related issue

None

Motivation and Context

Easier to skim markets and identify this ratio market.

How Has This Been Tested?

Crude testing in Chrome using local source override. Less than ideal.

Screenshots (if appropriate):

Showing from and to:

Kwenta_From Kwenta_To

@vercel
Copy link

vercel bot commented Oct 26, 2023

@Ondkloss is attempting to deploy a commit to the Kwenta Team on Vercel.

A member of the Team first needs to authorize it.

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #2807 (6a33942) into dev (f34b38d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #2807   +/-   ##
=======================================
  Coverage   51.29%   51.29%           
=======================================
  Files         424      424           
  Lines       13886    13886           
  Branches     3076     3076           
=======================================
  Hits         7123     7123           
  Misses       6480     6480           
  Partials      283      283           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Ondkloss
Copy link
Contributor Author

Ondkloss commented Oct 28, 2023

I can see from the fleek build that this is broken, apparently due to graph and 24h change dependence on this value.
Going for test environment to adapt.

@Ondkloss Ondkloss closed this Oct 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant