Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👷🏻 ✅ Add abs helpers to int interactions libraries #4

Merged
merged 6 commits into from
Mar 11, 2024

Conversation

tommyrharper
Copy link
Contributor

Description

Add abs helper functions to all int types, including abs128 and abs for int128 types. abs returns 256 sized types and abs128 returns 128 sized types, mirroring the functionality in the MathUtil in the snx repo.

Copy link

codecov bot commented Mar 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 21 lines in your changes are missing coverage. Please review.

Project coverage is 0.00%. Comparing base (dc0616c) to head (5f33723).

❗ Current head 5f33723 differs from pull request most recent head 671a2d9. Consider uploading reports for the commit 671a2d9 to get more accurate results

Files Patch % Lines
src/Int128/USDPerBaseInt128/Interactions.sol 0.00% 3 Missing ⚠️
src/Int128/USDPerQuantoInt128/Interactions.sol 0.00% 3 Missing ⚠️
src/Int128/BaseInt128/Interactions.sol 0.00% 2 Missing ⚠️
src/Int128/BaseQuantoPerUSDInt128/Interactions.sol 0.00% 2 Missing ⚠️
src/Int128/QuantoInt128/Interactions.sol 0.00% 2 Missing ⚠️
src/Int128/USDInt128/Interactions.sol 0.00% 2 Missing ⚠️
src/Int256/USDPerBaseInt256/Interactions.sol 0.00% 2 Missing ⚠️
src/Int256/BaseInt256/Interactions.sol 0.00% 1 Missing ⚠️
src/Int256/BaseQuantoPerUSDInt256/Interactions.sol 0.00% 1 Missing ⚠️
src/Int256/QuantoInt256/Interactions.sol 0.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@          Coverage Diff          @@
##            main      #4   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files         39      39           
  Lines        185     206   +21     
  Branches      17      17           
=====================================
- Misses       185     206   +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JaredBorders JaredBorders merged commit 3435a3e into main Mar 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants