Skip to content

Commit

Permalink
Merge pull request #494 from KxSystems/ee-pyfix
Browse files Browse the repository at this point in the history
Workaround for Python structuredText bug
  • Loading branch information
ecmel authored Jan 10, 2025
2 parents f3bfbd1 + ad17a1b commit fe87ed5
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
5 changes: 4 additions & 1 deletion src/classes/insightsConnection.ts
Original file line number Diff line number Diff line change
Expand Up @@ -430,7 +430,8 @@ export class InsightsConnection {
};

if (this.insightsVersion) {
if (compareVersions(this.insightsVersion, 1.12)) {
/* TODO: Workaround for Python structuredText bug */
if (!isPython && compareVersions(this.insightsVersion, 1.12)) {
body.returnFormat = isTableView ? "structuredText" : "text";
} else {
body.isTableView = isTableView;
Expand Down Expand Up @@ -475,6 +476,8 @@ export class InsightsConnection {
if (!response.data.error) {
if (isTableView) {
if (
/* TODO: Workaround for Python structuredText bug */
!isPython &&
this.insightsVersion &&
compareVersions(this.insightsVersion, 1.12)
) {
Expand Down
3 changes: 2 additions & 1 deletion src/services/resultsPanelProvider.ts
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,8 @@ export class KdbResultsViewProvider implements WebviewViewProvider {

if (
(!isInsights && !isPython) ||
(isInsights && connVersion && compareVersions(connVersion, 1.12))
/* TODO: Workaround for Python structuredText bug */
(!isPython && connVersion && compareVersions(connVersion, 1.12))
) {
rowData = this.updatedExtractRowData(results);
columnDefs = this.updatedExtractColumnDefs(results);
Expand Down

0 comments on commit fe87ed5

Please sign in to comment.