Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KXI-33265 - Fix Results tab for local connections #223

Merged
merged 3 commits into from
Jan 5, 2024
Merged

KXI-33265 - Fix Results tab for local connections #223

merged 3 commits into from
Jan 5, 2024

Conversation

Philip-Carneiro-KX
Copy link
Collaborator

Changes introduced by this PR

  • added workaround to node-q
  • get string as results for node-q execution, and handle it to transform into objects
  • add tests

@Philip-Carneiro-KX Philip-Carneiro-KX self-assigned this Jan 4, 2024
@kx-sonarqube
Copy link

kx-sonarqube bot commented Jan 5, 2024

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
94.4% 94.4% Coverage on New Code
0.0% 0.0% Duplication on New Code

See analysis details on SonarQube

@Philip-Carneiro-KX Philip-Carneiro-KX merged commit a0644f1 into dev Jan 5, 2024
5 checks passed
@Philip-Carneiro-KX Philip-Carneiro-KX deleted the KXI-33265 branch January 18, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ecmel ecmel ecmel approved these changes

@nfarrell-kx nfarrell-kx Awaiting requested review from nfarrell-kx

Assignees

@Philip-Carneiro-KX Philip-Carneiro-KX

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Philip-Carneiro-KX @ecmel