Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KXI-56563 Add structuredText and sampling to the VS Code wrapper #469

Merged
merged 5 commits into from
Jan 6, 2025

Conversation

acheung12
Copy link
Collaborator

Changes introduced by this PR

@acheung12 acheung12 marked this pull request as draft December 3, 2024 12:24
@acheung12 acheung12 changed the title changed how evaluate is handled WIP KXI-56563 Add structuredText and sampling to the VS Code wrapper Dec 3, 2024
@acheung12 acheung12 marked this pull request as ready for review December 3, 2024 12:25
@acheung12 acheung12 marked this pull request as draft December 3, 2024 12:25
@Philip-Carneiro-KX Philip-Carneiro-KX self-assigned this Dec 3, 2024
@Philip-Carneiro-KX Philip-Carneiro-KX self-requested a review December 3, 2024 13:52
@Philip-Carneiro-KX Philip-Carneiro-KX removed their assignment Dec 3, 2024
@ecmel
Copy link
Collaborator

ecmel commented Dec 22, 2024

@acheung12 The script gives an error on typeOf function. i_PRIMCODE and i_NONPRIMCODE should be defined inside the typeOf function as far as I can tell.

Also, for text results, the script does not return the actual calculated result.

@ecmel ecmel self-assigned this Dec 28, 2024
@ecmel ecmel marked this pull request as ready for review January 2, 2025 05:39
@ecmel
Copy link
Collaborator

ecmel commented Jan 3, 2025

@acheung12 Regarding sampling (#490) it works when uncommented, we can add supporting extension code after we merge this PR. We will slightly modify this script then. (Add a sampleFn param and call the sample function accordingly instead of returning structuredText). Since the function works manually, I am uncommenting the part.

@ecmel ecmel self-requested a review January 6, 2025 07:18
@ecmel ecmel merged commit 35df1fb into KxSystems:dev Jan 6, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants