-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KXI-58865 - [structuredText] char result renders incorrectly #499
Conversation
quantity | ||
]; | ||
quantity | ||
]; columns) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you need this addition? Scratchpad does not have this. Keep in mind scratchpad toStructuredText also does goes through the sampling function before being called however whose return value will be used for toStructuredText and is accurate.
@acheung12 This should be fixed in Insights scratchpad as well. (https://kxl.atlassian.net/browse/KXI-58865) since |
Scratchpad handles the raw response which looks correct to me. The results view is UI? |
Insights scratchpad returns the following for
It has only 1 value in array but count is 4. If this is correct, we should refactor extension code. |
@ecmel This is correct. Strings in Q are considered to be char vectors. Therefore, the count is "done" is 4 AKA 4 characters. I'll bring this up to someone on Magenta if you wish for a redesign but I believe this is correct. Below is a unit test that tests for the count and tostructText feature on scratchpad. This is considered correct. |
|
Changes introduced by this PR