Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrating PoolsideV1 #473

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Integrating PoolsideV1 #473

wants to merge 17 commits into from

Conversation

SocksNFlops
Copy link

Why did we need it?

  • Adding PoolsideV1 into Kyberswap Dex Lib
    • Pool List Updater: Returns addresses of all pools (and relevant button-token info)
    • Pool Tracker: Returns pool balances from a given pool address
    • Pool Simulator: Simulates the getAmountOut math (and does button-token conversions in and out)

Related Issue

Release Note

How Has This Been Tested?

  • Unit tests for Pool Simulator

Screenshots (if appropriate):

@NgoKimPhu
Copy link
Member

Hi @ChaiSomsri96 , can you help to include doc links to this dex in the description? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xh9n 0xh9n Awaiting requested review from 0xh9n

@piavgh piavgh Awaiting requested review from piavgh piavgh is a code owner

@it4rb it4rb Awaiting requested review from it4rb it4rb is a code owner

@NgoKimPhu NgoKimPhu Awaiting requested review from NgoKimPhu NgoKimPhu is a code owner

@lehainam-dev lehainam-dev Awaiting requested review from lehainam-dev lehainam-dev is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SocksNFlops @NgoKimPhu @ChaiSomsri96