chore: reuse http.Client

KyberNetwork · Dec 12, 2023 · b2aae4e · b2aae4e
1 parent b3c3f0b
commit b2aae4e
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/pkg/parser/oneinch/oneinch_test.go b/pkg/parser/oneinch/oneinch_test.go
@@ -85,6 +85,8 @@ func TestParseOneinchTradeLog(t *testing.T) {
 
 		require.Equal(t, true, strings.EqualFold("0x807cF9A772d5a3f9CeFBc1192e939D62f0D9bD38", order.Maker))
 		require.Equal(t, strings.ToLower("0xdac3a1ba8fa517c1d98ffecf092b2ad167440131b19dee3d782d0d7eadce01a2"), order.OrderHash)
+		require.Equal(t, "25583325494215510852", order.MakerTokenAmount)
+		require.Equal(t, "40450976402181226773533785758", order.TakerTokenAmount)
 	}
 
 }
diff --git a/pkg/rpcnode/client.go b/pkg/rpcnode/client.go
@@ -8,11 +8,13 @@ import (
 	"github.com/ethereum/go-ethereum/ethclient"
 	"io"
 	"net/http"
+	"time"
 )
 
 type Client struct {
-	rpcUrl    string
-	ethClient *ethclient.Client
+	httpClient *http.Client
+	rpcUrl     string
+	ethClient  *ethclient.Client
 }
 
 func NewClient(rpcUrl string) (*Client, error) {
@@ -21,6 +23,9 @@ func NewClient(rpcUrl string) (*Client, error) {
 		return nil, err
 	}
 	return &Client{
+		httpClient: &http.Client{
+			Timeout: 5 * time.Second,
+		},
 		rpcUrl:    rpcUrl,
 		ethClient: ethClient,
 	}, nil
@@ -47,15 +52,14 @@ func (c *Client) FetchTraceCall(ctx context.Context, txHash string) (types.CallF
 		return types.CallFrame{}, err
 	}
 
-	client := &http.Client{}
 	req, err := http.NewRequest("POST", c.rpcUrl, bytes.NewBuffer(b))
 
 	if err != nil {
 		return types.CallFrame{}, err
 	}
 	req.Header.Add("Content-Type", "application/json")
 
-	res, err := client.Do(req)
+	res, err := c.httpClient.Do(req)
 	if err != nil {
 		return types.CallFrame{}, err
 	}