chore: reuse abi.ABI

KyberNetwork · Dec 13, 2023 · ebc7980 · ebc7980
1 parent fe3b01c
commit ebc7980
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 10 deletions.
diff --git a/pkg/decoder/decoder.go b/pkg/decoder/decoder.go
@@ -2,21 +2,16 @@ package decoder
 
 import (
 	"encoding/hex"
+	"fmt"
 	"github.com/KyberNetwork/tradelogs/internal/types"
 	"github.com/ethereum/go-ethereum/accounts/abi"
 	"github.com/ethereum/go-ethereum/common"
-	"strings"
 )
 
-func Decode(abiStr string, input string) (*types.ContractCall, error) {
-	ABI, err := abi.JSON(strings.NewReader(abiStr))
-	if err != nil {
-		return nil, err
-	}
-	if err != nil {
-		return nil, err
+func Decode(ABI *abi.ABI, input string) (*types.ContractCall, error) {
+	if ABI == nil {
+		return nil, fmt.Errorf("missing abi")
 	}
-
 	inputBytes := common.FromHex(input)
 	method, err := ABI.MethodById(inputBytes)
 	if err != nil {

diff --git a/pkg/parser/oneinch/parser.go b/pkg/parser/oneinch/parser.go
@@ -120,7 +120,7 @@ func (p *Parser) recursiveDetectOneInchRFQTrades(tradeLog storage.TradeLog, log
 	isOneInchRFQTrade := p.isOneInchRFQTrades(log, traceCall.Logs)
 
 	if isOneInchRFQTrade {
-		contractCall, err := decoder.Decode(OneinchMetaData.ABI, traceCall.Input)
+		contractCall, err := decoder.Decode(p.abi, traceCall.Input)
 		if err != nil {
 			return tradeLog, err
 		}