Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

intergrate service maintain promotees list to tradelog v2 #92

Merged
merged 6 commits into from
Nov 7, 2024
Merged

intergrate service maintain promotees list to tradelog v2 #92

merged 6 commits into from
Nov 7, 2024

Conversation

iostream1308
Copy link
Member

No description provided.

linhnt3400
linhnt3400 reviewed Oct 30, 2024
View reviewed changes
v2/pkg/app/server.go Outdated Show resolved Hide resolved
v2/pkg/handler/trade_logs.go Outdated Show resolved Hide resolved
v2/pkg/handler/trade_logs.go Outdated Show resolved Hide resolved
v2/pkg/handler/trade_logs_test.go Outdated Show resolved Hide resolved
v2/pkg/promotionparser/parser.go Outdated Show resolved Hide resolved
v2/pkg/storage/promotees/storage.go Outdated Show resolved Hide resolved
v2/pkg/storage/promotees/storage.go Outdated Show resolved Hide resolved
linhnt3400
linhnt3400 reviewed Oct 30, 2024
View reviewed changes
Copy link
Contributor

@linhnt3400 linhnt3400 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you forget to push the migration file

@iostream1308 iostream1308 force-pushed the promotees-list-v2 branch 2 times, most recently from 845e899 to 5cb0130 Compare November 7, 2024 08:37
iostream1308 and others added 6 commits November 7, 2024 15:41
@iostream1308
intergrate service maintain promotees list to tradelog v2
796baba 
Signed-off-by: Duong Thanh Hien <[email protected]>
Signed-off-by: iostream1308 <[email protected]>
@iostream1308
fix according to comments
54e7157 
Signed-off-by: Duong Thanh Hien <[email protected]>
Signed-off-by: iostream1308 <[email protected]>
@iostream1308
fix test skip
b622c48 
Signed-off-by: Duong Thanh Hien <[email protected]>
Signed-off-by: iostream1308 <[email protected]>
@iostream1308
edit name of variables
c63959c 
Signed-off-by: Duong Thanh Hien <[email protected]>
Signed-off-by: iostream1308 <[email protected]>
@iostream1308
edit name of variables
e01ab08 
Signed-off-by: Duong Thanh Hien <[email protected]>
Signed-off-by: iostream1308 <[email protected]>
@iostream1308
reduce max time range
c9689ea 
Signed-off-by: Duong Thanh Hien <[email protected]>
Signed-off-by: iostream1308 <[email protected]>
@iostream1308 iostream1308 merged commit 20a0040 into main Nov 7, 2024
6 checks passed
@iostream1308 iostream1308 deleted the promotees-list-v2 branch November 7, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linhnt3400 linhnt3400 linhnt3400 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iostream1308 @linhnt3400