-
-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Support for AWS EventBridge for Shopify Webhooks #224
base: master
Are you sure you want to change the base?
Conversation
Hello @Kyon147 , I hope everything is going well. It's been a while since this PR was submitted, what are your thoughts on it? Is there anything else that needs to be changed or improved? |
Hey @usmanpakistan Could you update me on what the PR is for, what it looks to solve and how someone would set it up? Also, some of the tests are failing, could you take a look. |
@Kyon147 This PR resolve issue reported previously on the legacy laravel-shopify package. |
@Kyon147 Any update on this PR |
Your PR is still failing tests, resolve those first please |
Hey @usmanpakistan As @Jamesking56 mentions please fix the failing tests and I can re-review once they are good. |
@Jamesking56 @Kyon147 can I get some help with fixing these tests. I am not well versed with writing them. I have tried a lot to fix the tests but these are still failing |
No description provided.