Fix existing code linting issues, make CI PHP Lint job fail if code style violations are detected
#384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently there are linting violations, but the `PHP Lint` job is still passing. https://github.com/Kyon147/laravel-shopify/actions/workflows/lint.yml Most recent example: https://github.com/Kyon147/laravel-shopify/actions/runs/12164298709/job/33925618006 This change should ensure that the CI job will fail if PHP CS Fixer detects linting violations.
vendor/bin/php-cs-fixer fix PHP CS Fixer 3.68.3 Persian Successor by Fabien Potencier, Dariusz Ruminski and contributors. PHP runtime: 8.3.16 Running analysis on 1 core sequentially. You can enable parallel runner and speed up the analysis! Please see usage docs for more information. Loaded config default from "laravel-shopify/.php-cs-fixer.dist.php". Using cache file ".php-cs-fixer.cache". 216/216 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100% 1) src/resources/routes/shopify.php 2) src/resources/routes/api.php 3) src/Http/Middleware/VerifyScopes.php Fixed 3 of 216 files in 0.072 seconds, 18.00 MB memory used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there are linting violations, but the
PHP Lintjob is still green/passing.Most recent example: https://github.com/Kyon147/laravel-shopify/actions/runs/12164298709/job/33925618006
8ca670d should ensure that the CI job will fail if PHP CS Fixer detects linting violations.
328cc0f also fixes the 3 existing linting issues.