Implement equals and hashCode on WrappedComponent #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kashike
requested changes
Oct 10, 2024
mod-shared/src/main/java/net/kyori/adventure/platform/modcommon/impl/WrappedComponent.java
Outdated
Show resolved
Hide resolved
…n/impl/WrappedComponent.java Co-authored-by: Riley Park <[email protected]>
kashike
approved these changes
Oct 12, 2024
|
Should MC's components' equals() be modified to unwrap WrappedComponnents before comparing? Otherwise |
|
I think this is ready to merge, it should be backported to the 5.x series as well though I think since I expect 1.21.1 will live a relatively long life. |
zml2008
approved these changes
Oct 18, 2024
|
I've set up |
This was referenced Oct 18, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #162