Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crossdoc: Include transitive project dependencies in linking as well #145

Merged
merged 2 commits into from
Aug 28, 2023
Merged

crossdoc: Include transitive project dependencies in linking as well #145

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ef1159f
chore(testlib): Remove redundant blank line
zml2008 Aug 28, 2023
648bf89
fix(crossdoc): Include transitive project dependencies in linking as …
zml2008 Aug 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions indra-crossdoc/src/main/java/net/kyori/indra/crossdoc/CrossdocPlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,7 @@ private CrossdocExtension createExtension(final Project project) {
private void addUnpackedResultToJavadocConfiguration(final Project project) {
// Register unpacked Javadoc as an artifact for cross-linking
project.getConfigurations().matching(c -> c.getName().equals(JavaPlugin.JAVADOC_ELEMENTS_CONFIGURATION_NAME)).configureEach(c -> {
c.extendsFrom(project.getConfigurations().getByName(JavaPlugin.API_ELEMENTS_CONFIGURATION_NAME)); // include transitive dependencies
c.getOutgoing().getVariants().create("files", v -> {
final TaskProvider<Javadoc> javadocTask = project.getTasks().named(JavaPlugin.JAVADOC_TASK_NAME, Javadoc.class);
v.artifact(javadocTask.map(it -> it.getDestinationDir()), a -> {
Expand Down
1 change: 0 additions & 1 deletion indra-testlib/src/main/java/net/kyori/indra/test/LegacyGradleVersion.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@
import java.lang.annotation.Target;
import net.kyori.mammoth.test.TestVariant;


/**
* An annotation providing Gradle 7.x test variants, so this version can be overridden when running on Java versions
* that older Gradle versions do not support.
Expand Down