solution #1
solution #1
Conversation
| # write your code here | ||
| from datetime import datetime | ||
| from sys import argv | ||
| from os import mkdir, chdir |
There was a problem hiding this comment.
Suggest using absolute import of basic modules for better readability.
sys.argv more informative than simple argv, that can be simple named variable
| break | ||
|
|
||
| directories = argv[index2:index - 1] | ||
| else: |
There was a problem hiding this comment.
unnecessary else, use elif -d in argv, for simply note that only one param was enterd by console
| pass | ||
| chdir(directory) | ||
|
|
||
| with open(filename, "w") as f: |
There was a problem hiding this comment.
it must create file only when -f was passed into arguments, not every time of running script.
Also, you 'a' mode for opening file, for appending text! For now, you every time rewrite file, so old file info would be deleted on new write.
|
|
||
| directories = argv[index2:index - 1] | ||
| else: | ||
| filename = "file.txt" |
There was a problem hiding this comment.
failed setting filename for file, because -f argument wasn't pulled
| if "-f" in argv: | ||
| index = 0 | ||
|
|
||
| for _ in range(len(argv) - 1): |
There was a problem hiding this comment.
too hard reading, try give name of variable, change hard to read construction for _ in range(len(argv) - 1):
|
|
||
| while True: | ||
| line = input("Enter content line: ") | ||
| if line == "exit": |
There was a problem hiding this comment.
on task was keyword "stop", not "exit"
| line = input("Enter content line: ") | ||
| if line == "exit": | ||
| break | ||
| file_data.extend([line]) |
There was a problem hiding this comment.
for one line it's better to use .append() method, read about difference of extend and append methods of list
| break | ||
| file_data.extend([line]) | ||
|
|
||
| for directory in directories: |
There was a problem hiding this comment.
try to change that part for using os.makedirs(), instead of creating dir one by one
| chdir(directory) | ||
|
|
||
| with open(filename, "w") as f: | ||
| f.writelines(file_data) |
There was a problem hiding this comment.
Care about a new line ('\n') at the end of your file_data, to beautify output file with new lines. Or just iterate through file_data and do every line write
| for directory in directories: | ||
| try: | ||
| mkdir(directory) | ||
| except Exception: |
There was a problem hiding this comment.
Maybe we can exception particular errors? Try to test your program, and except errors that you will have!
No description provided.