fix(Counter): Resolve IndexOutOfBoundsException (see #14) #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobilarscheid
requested changes
Mar 31, 2020
| count++; | ||
| Files.write(counterFile.toPath(), count.toString().getBytes(Charset.forName("UTF-8"))); | ||
| List<String> lines = Files.readAllLines(counterFile.toPath()); | ||
| if (lines != null && lines.size() > 0){ |
There was a problem hiding this comment.
Hi Martin, in theory, this condition should never be false - increaseCounter is never called before the file was created (see callsite) So the error situation you are seeing seems to be some kind of illegal state and I have no clue how this can even occur.
I know that the change you propose will fix the errors you see, but also the plugin will just silently fail to write the metric - making the whole metric collection inherently unreliable, with a margin of error we couldn't even quantify. Only thing I can imagine (if we find no proper way to fix the actual faulty condition) would be a config flag "ignore errors" or something like this.
What do you think? Happy to here your proposals!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #14