Qualification salvage #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e on the cropped faces.
…rt it from other packages.
jws-1
requested changes
Feb 23, 2024
There was a problem hiding this comment.
Looks great! A successful salvage, I'd say; getting two new packages implementing brand new features, as well as fixing up bugs in other packages. 👍
I left a bunch of nitpicky suggestions / comments! Mostly CMake/package.xml related, and regarding the deletion of the actions that I had created.
| @@ -110,6 +113,7 @@ class TranscribeSpeechAction(object): | |||
| self._action_server.start() | |||
|
|
|||
| def _timer_cb(self, _) -> None: | |||
| return | |||
There was a problem hiding this comment.
Did we decide to keep it like this permanently? If so, let's just get rid of the timer altogether.
common/vision/lasr_vision_deepface/src/lasr_vision_deepface/deepface.py
Outdated
Show resolved
Hide resolved
common/vision/lasr_vision_deepface/src/lasr_vision_deepface/deepface.py
Outdated
Show resolved
Hide resolved
Comment on lines
123
to
125
| command_database = get_command_database(index_path, command_path) | ||
| command_list = load_commands(command_path) | ||
| model = SentenceTransformer("all-MiniLM-L6-v2") |
There was a problem hiding this comment.
Might be a stupid question, but is it worth caching this stuff?
common/vector_databases/lasr_vector_databases_faiss/package.xml
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.