FindPerson & FindNamedPerson #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-barker
reviewed
Apr 18, 2024
m-barker
approved these changes
Apr 18, 2024
| # TODO: make this smarter,e.g. levenshtein distance | ||
| if "yes" in userdata.transcribed_speech.lower(): | ||
| return "succeeded" | ||
| return "failed" |
There was a problem hiding this comment.
Same here for error handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces:
FindPersonskill, which navigates to a set of waypoints (the order of which is determined by computing a "minimum" Hamiltonian path"), and stops when a person is found.FindNamedPersonskill, which extendsFindPersonto find a specific person by asking encountered people if they are in-fact that person.cv2_pclconversions more flexible.Future work could refactor the two separate skills to promote modularity.