Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPSR QA & Repeat states #140

Merged
merged 24 commits into from
Mar 11, 2024
Merged

Conversation

m-barker
Copy link
Collaborator

@m-barker m-barker commented Mar 6, 2024

No description provided.

@m-barker m-barker marked this pull request as ready for review March 7, 2024 14:33
@m-barker m-barker requested a review from jws-1 March 7, 2024 14:33
Copy link
Member

@jws-1 jws-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work so far! It's great to see you start working on skills already 😀! I've left a few minor comments, alongside them, I think it would be very useful if the GetQuestion state was turned into a generic skill (such as SayAndListen?) where the robot says something and retrieves an answer from the person we are interacting with - the same goes for the QuestionAnswerStateMachine.

From an organisational standpoint, we could have nodes/commands and launch/commands directories, where we keep demos for commands that we can currently execute. What do you think?

@m-barker
Copy link
Collaborator Author

m-barker commented Mar 8, 2024

Great work so far! It's great to see you start working on skills already 😀! I've left a few minor comments, alongside them, I think it would be very useful if the GetQuestion state was turned into a generic skill (such as SayAndListen?) where the robot says something and retrieves an answer from the person we are interacting with - the same goes for the QuestionAnswerStateMachine.

From an organisational standpoint, we could have nodes/commands and launch/commands directories, where we keep demos for commands that we can currently execute. What do you think?

GetPhrase seems like a useful generic skill -- will move it there! Perhaps I can alter the QuestionAnswerStateMachine to some generic lookup that returns the most similar sentence in a text file, and use that for the GPSR Q/A.

I like the idea of command directories and nodes; once we have fully fleshed out the set of state machines we need to cover all the commands, we can then map any natural language command to one of these state machines and fill with appropriate parameters

@jws-1 jws-1 merged commit 8e00cad into LASR-at-Home:main Mar 11, 2024
1 check passed
@m-barker m-barker deleted the gpsr_question_answer branch March 12, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants