-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GPSR QA & Repeat states #140
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work so far! It's great to see you start working on skills
already 😀! I've left a few minor comments, alongside them, I think it would be very useful if the GetQuestion
state was turned into a generic skill (such as SayAndListen
?) where the robot says something and retrieves an answer from the person we are interacting with - the same goes for the QuestionAnswerStateMachine
.
From an organisational standpoint, we could have nodes/commands
and launch/commands
directories, where we keep demos for commands that we can currently execute. What do you think?
common/vector_databases/lasr_vector_databases_faiss/nodes/txt_index_service
Show resolved
Hide resolved
common/vector_databases/lasr_vector_databases_faiss/nodes/txt_query_service
Show resolved
Hide resolved
common/vector_databases/lasr_vector_databases_faiss/nodes/txt_query_service
Outdated
Show resolved
Hide resolved
...ctor_databases/lasr_vector_databases_faiss/src/lasr_vector_databases_faiss/database_utils.py
Outdated
Show resolved
Hide resolved
...bases/lasr_vector_databases_faiss/src/lasr_vector_databases_faiss/get_sentence_embeddings.py
Outdated
Show resolved
Hide resolved
I like the idea of command directories and nodes; once we have fully fleshed out the set of state machines we need to cover all the commands, we can then map any natural language command to one of these state machines and fill with appropriate parameters |
No description provided.