Receptionist update with deepface #212
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- When indicating a free seat with its head, it will move on if the head is stuck - Give the guest 5 seconds to be seated before moving on
haiwei-luo
changed the title
haiwei-luo
changed the title
|
Not sure the "tasks/receptionist/src/receptionist/states/get_attributes.py" file has been resolved correctly, would appreciate another look |
haiwei-luo
changed the title
jws-1
requested changes
Jun 10, 2024
common/vision/lasr_vision_deepface/src/lasr_vision_deepface/deepface.py
Outdated
Show resolved
Hide resolved
| @@ -13,7 +13,7 @@ class ParseNameAndDrink(smach.State): | |||
| def __init__( | |||
| self, | |||
| guest_id: str, | |||
| param_key: str = "receptionist/priors", | |||
| param_key: str = "/priors", | |||
There was a problem hiding this comment.
Suggested change
| param_key: str = "/priors", | |
| param_key: str = "/receptionist/priors", |
There was a problem hiding this comment.
/receptionist/... breaks the code.
tasks/receptionist/src/receptionist/states/get_name_and_drink.py
Outdated
Show resolved
Hide resolved
tasks/receptionist/src/receptionist/states/get_name_and_drink.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
I feel like this should be a skill instead
There was a problem hiding this comment.
I'll look into this.
Comment on lines
+12
to
+25
| class GuestSeatWait(smach.State): | ||
| def __init__(self): | ||
| smach.State.__init__(self, outcomes=["succeeded", "failed"]) | ||
|
|
||
| def execute(self, userdata) -> str: | ||
| # Wait 5 seconds for user to sit down | ||
| try: | ||
| wait_time = 5 | ||
| print(f"Waiting for {wait_time} seconds for the user to sit down.") | ||
| rospy.sleep(wait_time) | ||
| return "succeeded" | ||
| except: | ||
| print("Waiting for the guest to sit down failed") | ||
| return "failed" |
There was a problem hiding this comment.
Might be worth adding a generic Sleep skill that takes the number of seconds to sleep for in the constructor?
There was a problem hiding this comment.
I'll look into it
added 2 commits
June 12, 2024 15:37
|
This PR is deprecated as PR #221 has taken over |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added into receptionist: