Updated attributes detection, solved issue related to bodypix update. #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Message Change
fixed that torsal and head frames were inversed.
merge from main
…fucking tired and haven't fuking fixed.
jws-1
reviewed
Jun 10, 2024
| @@ -354,7 +549,9 @@ def binary_erosion_dilation( | |||
|
|
|||
| # Check if the length of thresholds matches the number of channels | |||
| if len(thresholds) != tensor.size(1): | |||
| raise ValueError("Length of thresholds must match the number of channels") | |||
| # the error should be here, just removed for now since there's some other bug I haven't fixed. | |||
There was a problem hiding this comment.
It's not actually fixed haha, but it doesn't affect anything except the cloth labels detected are currently messed up. Was working with Zoe and Haiwei today, I think we need my code merged to get rid of that feature service issue anyway :)
common/vision/lasr_vision_feature_extraction/src/lasr_vision_feature_extraction/__init__.py
Outdated
Show resolved
Hide resolved
common/vision/lasr_vision_feature_extraction/src/lasr_vision_feature_extraction/__init__.py
Outdated
Show resolved
Hide resolved
added 5 commits
June 11, 2024 14:37
Corrected the typo in the function name 'load_cloth_classidifer_model' to 'load_cloth_classifier_model'. Removed two logging statements from describe_people.py that were used for debugging purposes.
jws-1
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.