Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(ROS2): lasr_vision_interfaces #271

Merged
merged 5 commits into from
Sep 27, 2024
Merged

(ROS2): lasr_vision_interfaces #271

merged 5 commits into from
Sep 27, 2024

Conversation

jws-1
Copy link
Member

@jws-1 jws-1 commented Sep 25, 2024

Simple PR creating the lasr_vision_interfaces package. This will be required for porting all of the vision packages. Currently, this won't build as there are no messages to generate, but this should save repeated work.

@jws-1 jws-1 changed the title (ROS2): lasr_vision_msgs (ROS2): lasr_vision_interfaces Sep 25, 2024
Copy link
Collaborator

@haiwei-luo haiwei-luo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Does the lasr_vision_interfaces basically offer a template (format to follow) when we create our own packages in the vision directory?

@jws-1
Copy link
Member Author

jws-1 commented Sep 27, 2024

Looks good. Does the lasr_vision_interfaces basically offer a template (format to follow) when we create our own packages in the vision directory?

It could - the main point is that we need somewhere to put message/service definitions. Before we had lasr_vision_msgs, this will do the same job

@jws-1 jws-1 merged commit be5d676 into ros2 Sep 27, 2024
1 check passed
@jws-1 jws-1 deleted the ros2-vision_msgs branch September 27, 2024 06:38
@haiwei-luo
Copy link
Collaborator

Ah I see

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants