Fix/logging adapter #110
Merged
Fix/logging adapter #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to use the logging adapter, which is included in banzai.logs.get_logger - this will bring it in by default
The new base image of python 3.11 means we needed to update a few dependencies
mgdaily
commented
Nov 27, 2023
|
|
||
| RUN pip install astropy==4.2 | ||
| RUN pip install astropy==5.3.4 |
There was a problem hiding this comment.
this is what BANZAI is using. needed to update as the base python version was upgraded
mgdaily
commented
Nov 27, 2023
|
|
||
| USER root | ||
|
|
||
| RUN conda install -y coveralls sphinx statsmodels docutils=0.15 |
There was a problem hiding this comment.
Conda was not able to solve with docutils pinned to 0.15
Also change tox to test with python 3.8/3.9 as 3.7 is EOL
cmccully
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates to use the logging adapter that was created in BANZAI, and also updates the base BANZAI image in the Dockerfile. I've ran the e2e tests using the updated Docker image and they pass.