Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some environment updates and adding docker builds to ghcr #377

Merged
merged 5 commits into from
Oct 31, 2023

Conversation

cmccully
Copy link
Collaborator

No description provided.

@cmccully cmccully requested a review from sfoale October 31, 2023 13:36
Copy link
Contributor

@sfoale sfoale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor query

@@ -80,7 +79,7 @@ spec:
periodSeconds: 1
timeoutSeconds: 10
- name: banzai-celery-workers
image: @BANZAI_IMAGE@
image: banzai:test-latest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this change intended? It looks like you're using a locally built image.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is. This is a longer term fix we are making as we move away from jenkins.

@cmccully cmccully merged commit c0ee986 into master Oct 31, 2023
6 checks passed
@cmccully cmccully deleted the feature/gitops branch April 15, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants