Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open in Datalab #74

Merged
merged 2 commits into from
Nov 4, 2024
Merged

Open in Datalab #74

merged 2 commits into from
Nov 4, 2024

Conversation

LTDakin
Copy link
Collaborator

@LTDakin LTDakin commented Nov 4, 2024

Adds a button to the MyGallery component that opens the images in datalab with their proposal, observation, and date. Added datalab url to the config as well

Screen.Recording.2024-11-04.at.2.53.27.PM.mov

@LTDakin LTDakin self-assigned this Nov 4, 2024
@LTDakin LTDakin added the enhancement New feature or request label Nov 4, 2024
capetillo
capetillo approved these changes Nov 4, 2024
View reviewed changes
Copy link
Collaborator

@capetillo capetillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beautiful 🤌 looks good to me!

mgdaily
mgdaily approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@mgdaily mgdaily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

jnation3406
jnation3406 approved these changes Nov 4, 2024
View reviewed changes
Copy link

@jnation3406 jnation3406 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great but I think it would be nice if the button was inline with the date and was like an open in new window icon type button

@LTDakin LTDakin merged commit 4be2b7f into main Nov 4, 2024
1 check passed
@LTDakin LTDakin deleted the feature/open-in-datalab branch November 4, 2024 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@capetillo capetillo capetillo approved these changes

@jnation3406 jnation3406 jnation3406 approved these changes

@mgdaily mgdaily mgdaily approved these changes

@zemogle zemogle Awaiting requested review from zemogle

Assignees

@LTDakin LTDakin

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LTDakin @mgdaily @jnation3406 @capetillo