Feature/pagination #75
Conversation
…immediately shows username
There was a problem hiding this comment.
It kind of looks like anytime there is a change in session (new session added or whatever) it will try to reload the thumbnails for all sessions, not just the new ones added? I guess that's fine for now but we should make sure this doesn't make too many calls and take to long for people with large numbers of requests, or large numbers of thumbnails per request.
src/components/Images/MyGallery.vue
Outdated
| const getThumbnails = async (observationId) => { | ||
| await fetchApiCall({ | ||
| url: configurationStore.thumbnailArchiveUrl + `thumbnails/?observation_id=${observationId}&size=large`, | ||
| url: `${configurationStore.thumbnailArchiveUrl}thumbnails/?observation_id=${observationId}&size=large`, |
There was a problem hiding this comment.
Maybe I'm missing something, but if these thumbnails are for the page where it lists your sessions and all their little thumbnails under the dates then I think it should use the small thumbnails, not the large ones. The large ones are like 1/2 your screen size so I would save those for like opening a single image into a larger view...
There was a problem hiding this comment.
okey dokes! I should really start testing on the ipad
There was a problem hiding this comment.
and to respond to your top comment, I can definitely add the limit query param to the call. But I'm not sure what the solution could be. Maybe we talk about this in zoom
FEATURE: Pagination for faster thumbnail loading
Background:
When the Dashboard first loaded, it would take a really long time to fetch for the thumbnails (and most of the time it would time out).
Implementation:
loadThumbnailsForPage: This loads and displays thumbnails for sessions on the current page. It calculates the start and end indices based oncurrentPageandpageSize, clears the existingthumbnailsMap, and asynchronously fetches thumbnails for each session. This function will make the request togetThumbnailsonly 5 times per page (i.e.pageSize)sessionsWithThumbnails: Updated to filter and return sessions for the current page that have associated thumbnail urls. Aka only sessions with available thumbnails are displayedfilteredSessionsbecause when the component first mounts it's an empty array and that would not trigger the cascade ofloadThumbnailsForPage-->getThumbnailsTwo other small fixes
&in theobsPortalDatastoreAppVISUALS
User logs in, username is on the right (rather than
log inbutton) and thumbnails load quickly. This is also after clearing my cache so it's reliable!Screen.Recording.2024-11-05.at.1.31.46.PM.mov